Bump to KCL v2.7.2 #109
Open
Bump to KCL v2.7.2 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets up the development environment for the logstash-input-kinesis plugin. It includes: - .envrc: Configures JRuby, Logstash paths, AWS credentials (optional), and adds vendor jars to the classpath. - .ruby-version: Specifies JRuby version. - Makefile: Defines common tasks (install, test, clean). - Rakefile: Uses jar-dependencies to manage Java dependencies. The Jars::Installer.new.vendor_jars! method is now called with `write_require_file: false` to prevent writing a require file.
- Migrate to Kinesis Client Library (KCL) v2.7.2 - Add support for custom endpoint configuration - Improve LocalStack and testing compatibility - Update AWS SDK dependencies and configuration - Enhance error handling and logging - Refactor worker and record processing logic - Add integration test infrastructure Update to 2.7.2
|
💚 CLA has been signed |
Author
Done! |
Author
|
Can't see any of the travis CI logs.. so 🤷 |
Both jobs failed with the same error, look like there's something broken in the CI |
|
May I ask, how to run the bundle to get the gem generated ? Then I ran I did try AI to try help me, but still no luck. This is the complete log |
Author
|
Hello @felixho1 , I use fedora locally + logstash installed via rpm + direnv (that creates the required environment for building it). That said, I also included a Dockerfile so that the build process can be done independently of the "outside" environment. For that, you just need to have docker available and run: $ docker build --target builder-kinesis --tag builder-kinesis .
$ docker run -ti -v $(pwd)/output:/output --entrypoint bash builder-kinesis -c "cp /build/logstash-input-kinesis-*.gem /output/"
$ ls -lah output/*gem
-rw-r--r--. 1 root root 66M Jan 24 15:14 output/logstash-input-kinesis-3.0.0-java.gem |
|
@nunofernandes Thank you so much for your help raising the PR. And thank you for the tips to build with docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Upgrade Logstash Kinesis Input Plugin to AWS Kinesis Client Library (KCL) v2.7.2. This major version upgrade introduces enhanced compatibility with AWS SDK v2, improved LocalStack testing support, and more robust endpoint configuration.
What does this PR do?
Why is it important/What is the impact to the user?
This PR fixes an impending EOL on the AWS KCL v1*.
Checklist
Author's Checklist
How to test this PR locally
You need to have docker compose and make.
Related issues
Use cases
n/a
Screenshots
n/a
Logs
Been running that in the last 24 hours without issues. Log volume is +70k logs / minute.